Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set macOS deployment version to 12.0 #1511

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented May 10, 2024

fix #1510

The minimum possible supported version is bound by Qt -> macOS 11, but it no longer gets updates from Apple.

https://doc.qt.io/qt-6/supported-platforms.html

@shenlebantongying
Copy link
Collaborator Author

Actually, it is bound by homebrew, which requires macOS to be at least 12.0 😅

https://docs.brew.sh/Installation#macos-requirements

Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@shenlebantongying shenlebantongying changed the title fix: set macOS minimum deployment version fix: set macOS deployment version to 12.0 May 10, 2024
@shenlebantongying shenlebantongying merged commit 685b2ec into xiaoyifang:staged May 10, 2024
13 checks passed
@shenlebantongying shenlebantongying deleted the fix/cmake-mac-miniversion branch May 10, 2024 19:07
@shenlebantongying
Copy link
Collaborator Author

otool -l ./GoldenDict-ng.app/Contents/MacOS/GoldenDict-ng | grep minos shows 12.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does the Mac version no longer support Mac 12?
1 participant